Skip to content

build: prevent publishing from the wrong branch #12831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2018
Merged

build: prevent publishing from the wrong branch #12831

merged 1 commit into from
Aug 25, 2018

Conversation

@devversion
Copy link
Member

@devversion devversion commented Aug 25, 2018

  • Patch releases should be published from patch publish branches with the format: {}.{}.x
  • Minor releases should be published from minor publish branches with the format: {}.x
  • Major releases should be published from the master branch.

Closes #12655

@devversion
build: prevent publishing from the wrong branch
5c60d91 
* Patch releases should be published from patch publish branches with the format: `{}.{}.x`
* Minor releases should be published from minor publish branches with the format: `{}.x`
* Major releases should be published from the `master` branch.

Closes angular#12655
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Aug 25, 2018
@devversion devversion requested a review from jelbourn as a code owner August 25, 2018 14:11
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 25, 2018
jelbourn
jelbourn approved these changes Aug 25, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 25, 2018
@jelbourn jelbourn merged commit e5e5b68 into angular:master Aug 25, 2018
jelbourn pushed a commit that referenced this pull request Aug 29, 2018
@devversion @jelbourn
build: prevent publishing from the wrong branch (#12831)
b989540 
* Patch releases should be published from patch publish branches with the format: `{}.{}.x`
* Minor releases should be published from minor publish branches with the format: `{}.x`
* Major releases should be published from the `master` branch.

Closes #12655
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 9, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prevent publishing from the wrong branch

3 participants

@devversion @jelbourn @googlebot