perf(table): prevent unnecessary reflow with sticky row #12786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
added
perf
The offset of a sticky row is calculated by summing up the heights of the previous sticky rows. As the access to the height causes a forced reflow this is now skipped when there is only one row.
Contributor
Author
|
@devversion friendly ping |
devversion
approved these changes
Sep 14, 2018
devversion
added
pr: lgtm
action: merge
Member
|
Sorry @nename0 for the delay. This PR looks good to me, but I wanted to get a second review from @andrewseguin. |
josephperrott
changed the title
Contributor
Author
|
Thanks! |
roboshoes
pushed a commit
to roboshoes/material2
that referenced
this pull request
Oct 23, 2018
The offset of a sticky row is calculated by summing up the heights of the previous sticky rows. As the access to the height causes a forced reflow this is now skipped when there is only one row.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
StickyStylegetBoundingClientRect()is called to calculate the offset of the next sticky row. This causes a forced reflow(link). However this is not needed when there is only one sticky row.