fix(form-field): properly handle measuring outline gap when label is not initially in the dom #12782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephperrott
added
the
target: patch
googlebot
added
the
cla: yes
josephperrott
force-pushed
the
form-field-outline
branch
3 times, most recently
from
de05bb3 to
94f0642
Compare
josephperrott
changed the title
josephperrott
force-pushed
the
form-field-outline
branch
from
94f0642 to
3a8b9ff
Compare
mmalerba
reviewed
Aug 22, 2018
src/lib/form-field/form-field.ts
Outdated
|
|
||
| // If the element is not present in the DOM, the outline gap will need to be calculated | ||
| // the next time it is checked and in the DOM. | ||
| if (document && !document.documentElement.contains(this._elementRef.nativeElement)) { |
Contributor
There was a problem hiding this comment.
use platform.isBrowser https://github.com/angular/material2/blob/master/src/cdk/platform/platform.ts#L29 (I see there's already a check for this down below, maybe you can simplify the logic a bit)
josephperrott
force-pushed
the
form-field-outline
branch
2 times, most recently
from
31a6a42 to
d46964c
Compare
josephperrott
force-pushed
the
form-field-outline
branch
from
d46964c to
457847f
Compare
mmalerba
approved these changes
Aug 23, 2018
mmalerba
added
pr: lgtm
action: merge
jelbourn
pushed a commit
that referenced
this pull request
Aug 29, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #12780