refactor(schematics): run tests for template files #12562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
pr: merge safe
target: major
googlebot
added
the
cla: yes
josephperrott
added
pr: needs rebase
and removed
action: merge
* No longer skips tests that verify that the template files are properly created as part of the schematic. This is now possible because we have a more clean workaround for the schematic testing (related: bazelbuild/rules_typescript#154) * Updates all schema.json files to properly match the current implementation of the `build-component` function (consistent with `ng g component`) * Due to the new workaround for the schematic testing we can also now re-add the `schema.json` files to the collection. The schema files are needed for the schematics when using `ng generate`)
devversion
force-pushed
the
refactor/schematics-run-tests-template
branch
from
a05695e to
d7dc93e
Compare
devversion
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
require('./file.json')or __dirname work as expected in JavaScript but not TypeScript bazelbuild/rules_typescript#154)build-componentfunction (consistent withng g component)schema.jsonfiles to the collection. The schema files are needed for the schematics when usingng generate)