fix(radio): ng-touched incorrectly being set on click #12560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
josephperrott
added
pr: lgtm
action: merge
devversion
force-pushed
the
fix/radio-button-ng-touched-click
branch
from
cc87f0a to
9c83797
Compare
devversion
added
the
P3
jelbourn
added
P2
devversion
force-pushed
the
fix/radio-button-ng-touched-click
branch
from
9c83797 to
49eea2b
Compare
* The `ControlValueAccessor` `onTouched` should be just called if a radio-button blurred. Right now, the `ng-touched` state will be immediately set if someone presses SPACE or clicks on a radio-button.
devversion
force-pushed
the
fix/radio-button-ng-touched-click
branch
from
49eea2b to
9ca18d5
Compare
josephperrott
pushed a commit
that referenced
this pull request
Mar 7, 2019
* The `ControlValueAccessor` `onTouched` should be just called if a radio-button blurred. Right now, the `ng-touched` state will be immediately set if someone presses SPACE or clicks on a radio-button.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ControlValueAccessoronTouchedshould be just called if a radio-button blurred. Right now, theng-touchedstate will be immediately set if someone presses SPACE or clicks on a radio-button.