Skip to content

fix(chips): focus indication not visible in high contrast mode #12431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2018
Merged

fix(chips): focus indication not visible in high contrast mode #12431

merged 1 commit into from
Aug 1, 2018

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 29, 2018 •
edited
Loading

Fixes not being able to tell which chip is focused in high contrast mode. For reference:

angular_material_ -_microsoft_edge_2018-07-29_22-39-01

@crisbeto
fix(chips): focus indication not visible in high contrast mode
1345452 
Fixes not being able to tell which chip is focused in high contrast mode.
@crisbeto crisbeto added Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Jul 29, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 29, 2018
jelbourn
jelbourn approved these changes Jul 30, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 30, 2018
@jelbourn jelbourn merged commit bcf4c9f into angular:master Aug 1, 2018
jelbourn pushed a commit that referenced this pull request Aug 7, 2018
@crisbeto @jelbourn
fix(chips): focus indication not visible in high contrast mode (#12431)
3652707 
Fixes not being able to tell which chip is focused in high contrast mode.
jelbourn pushed a commit that referenced this pull request Aug 7, 2018
@crisbeto @jelbourn
fix(chips): focus indication not visible in high contrast mode (#12431)
bea52b6 
Fixes not being able to tell which chip is focused in high contrast mode.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 9, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto @jelbourn @googlebot