fix(autocomplete): reopening closed autocomplete when coming back to tab #12372
Conversation
googlebot
added
the
cla: yes
| /** | ||
| * Whether the autocomplete can open the next time it is focused. Used to prevent a focused, | ||
| * closed autocomplete from being reopened if the user switches to another tab and then | ||
| * comes back. |
There was a problem hiding this comment.
Clarify "browser tab" to disambiguate from a tabs component?
|
|
||
| ngOnDestroy() { | ||
| if (typeof window !== 'undefined') { | ||
| window.removeEventListener('blur', this._windowBlurHandler); |
There was a problem hiding this comment.
This will be a good use for the Page Lifecycle API... someday.
There was a problem hiding this comment.
The browser support isn't too horrible tbh, but I think that this is case is simple enough that we can get away with the event.
| * Event handler for when the window is blurred. Needs to be an | ||
| * arrow function in order to preserve the context. | ||
| */ | ||
| private _windowBlurHandler = () => { |
There was a problem hiding this comment.
Move this up to live next to the other class properties?
| */ | ||
| private _windowBlurHandler = () => { | ||
| this._canOpenOnNextFocus = | ||
| document.activeElement !== this._element.nativeElement || this.panelOpen; |
There was a problem hiding this comment.
Add a comment that explains the rationale behind this logic?
crisbeto
force-pushed
the
12337/autocomplete-reopen
branch
from
a2bab41 to
b87f005
Compare
|
Feedback has been addressed @jelbourn. |
jelbourn
added
pr: lgtm
action: merge
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
Fixes a closed autocomplete being reopened, if the user moves to another tab and coming back to the current one, while the input is still focused. Fixes angular#12337.
crisbeto
force-pushed
the
12337/autocomplete-reopen
branch
from
b87f005 to
2094132
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
3 participants
Fixes a closed autocomplete being reopened, if the user moves to another tab and coming back to the current one, while the input is still focused.
Fixes #12337.