Skip to content

Conversation

@crisbeto
Copy link
Member

Reworks the demos that were using the docs examples to avoid having to hard-code the list of examples for each component.

@crisbeto crisbeto requested a review from andrewseguin as a code owner July 23, 2018 20:47
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 23, 2018
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 24, 2018
'table-sticky-complex',
'table-sticky-complex-flex',
];
examples = Object.keys(EXAMPLE_COMPONENTS).filter(example => example.startsWith('table-'));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about the cdk-table-*? 😃

Reworks the demos that were using the docs examples to avoid having to hard-code the list of examples for each component.
@crisbeto crisbeto force-pushed the example-list-dynamic branch from a23fa1c to 18cefb4 Compare July 24, 2018 07:15
@mmalerba mmalerba merged commit f4fcf78 into angular:master Jul 24, 2018
mmalerba pushed a commit that referenced this pull request Jul 30, 2018
Reworks the demos that were using the docs examples to avoid having to hard-code the list of examples for each component.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants