Skip to content

feat(menu): align with 2018 material design spec #12331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2018
Merged

feat(menu): align with 2018 material design spec #12331

merged 1 commit into from
Aug 31, 2018

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 23, 2018 •
edited
Loading

Aligns the menu component with the latest version of the Material design spec. Includes making overlapTrigger false by default.

angular_material_-_google_chrome_2018-07-24_20-04-12

angular_material_-_google_chrome_2018-07-24_20-06-18

@crisbeto crisbeto added the target: major This PR is targeted for the next major release label Jul 23, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 23, 2018
jelbourn
jelbourn approved these changes Jul 23, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Caretaker note: Screenshot failures likely

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jul 23, 2018
@jelbourn
Copy link
Member

jelbourn commented Jul 23, 2018

@crisbeto can you change the commit message to feat since this is user-facing? Also, it would be better to say "2018 Material Design spec" since I'm sure there will be more updates in future years

@crisbeto crisbeto changed the title refactor(menu): align with new material spec feat(menu): align with 2018 material design spec Jul 23, 2018
@crisbeto crisbeto removed the action: merge The PR is ready for merge by the caretaker label Jul 24, 2018
@crisbeto
feat(menu): align with 2018 material design spec
629c550 
Aligns the menu component with the latest version of the Material design spec. Includes making `overlapTrigger` false by default.
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 24, 2018
@crisbeto crisbeto mentioned this pull request Aug 4, 2018
Closed
@jelbourn jelbourn added the P2 The issue is important to a large percentage of users, with a workaround label Aug 14, 2018
@jelbourn jelbourn merged commit c812268 into angular:master Aug 31, 2018
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 9, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto @jelbourn @googlebot