fix(checkbox): error when disabling while focused #12327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
the
target: patch
googlebot
added
the
cla: yes
jelbourn
reviewed
Jul 24, 2018
src/lib/checkbox/checkbox.ts
Outdated
| this._onTouched(); | ||
| // Do not immediately mark the component as touched because it can happen that the `blur` | ||
| // event from `FocusMonitor` fires, while the component is checked after a change detection. | ||
| // Immediately updating would then result in a changed after checked exception. Rel: #12323 |
Member
There was a problem hiding this comment.
Same comment here as the slide-toggle PR
* Fixes that Angular throws an ExpressionChangedAfterItHasBeenCheckedError when disabling the checkbox while the component has been focused. * Adds missing test for `NgModel` states after value change through view. Related angular#12323
devversion
force-pushed
the
fix/checkbox-changed-after-checked
branch
from
c0da972 to
6439788
Compare
jelbourn
added
pr: lgtm
action: merge
jelbourn
pushed a commit
that referenced
this pull request
Aug 7, 2018
* Fixes that Angular throws an ExpressionChangedAfterItHasBeenCheckedError when disabling the checkbox while the component has been focused. * Adds missing test for `NgModel` states after value change through view. Related #12323
jelbourn
pushed a commit
that referenced
this pull request
Aug 7, 2018
* Fixes that Angular throws an ExpressionChangedAfterItHasBeenCheckedError when disabling the checkbox while the component has been focused. * Adds missing test for `NgModel` states after value change through view. Related #12323
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NgModelstates after value change through view.NgModeltests a bitRelated #12323