chore: remove screenshot testing #12155
Merged
+3
−12,924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devversion
commented
Jul 11, 2018
devversion
commented
- Removes the screenshot test tool since Angular Material is visually being tested inside of Google.
devversion
requested review from
andrewseguin,
crisbeto,
jelbourn,
josephperrott,
mmalerba and
tinayuangao
as code owners
googlebot
added
the
cla: yes
* Removes the screenshot test tool since Angular Material is visually being tested inside of Google.
devversion
force-pushed
the
chore/screenshot-testing-remove
branch
from
4d0aa56 to
efd6c2b
Compare
jelbourn
added
pr: lgtm
action: merge
Contributor
|
@jelbourn @tinayuangao @devversion Is there anything public related to the visual testing for Google products ? I'm very interested on visual regression tools, specially if its made for Angular ! 😀 |
Member
|
It's all internal to Google presently. |
victoriaaa234
pushed a commit
that referenced
this pull request
Jul 25, 2018
Removes the screenshot test tool since Angular Material is visually being tested inside of Google.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.