chore(toolbar): deprecate unused landscape row-height variable #12129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
the
target: minor
googlebot
added
the
cla: yes
Member
|
@devversion unfortunately we're not adding dense mode to any individual components. If we were to do that, I would want to have a consistent approach for the entire library, uniform density levels, and a way to only get the CSS that you're using. |
Member
Author
|
Makes sense. I think I just went to quickly to the implementation and forgot about #4597. Though I want to keep some changes in regards to the deprecation of the |
devversion
force-pushed
the
feat/toolbar-dense
branch
from
883b86c to
6a63e55
Compare
devversion
added
target: patch
* Deprecates the unused landscape row-height variable. The logic for this has been removed a long time ago, and the SCSS variable should be removed at some point. * Makes the host bindings more clear by expanding the truthy and falsy check.
devversion
force-pushed
the
feat/toolbar-dense
branch
from
6a63e55 to
f35c26f
Compare
devversion
changed the title
jelbourn
added
pr: lgtm
action: merge
victoriaaa234
pushed a commit
that referenced
this pull request
Jul 25, 2018
* Deprecates the unused landscape row-height variable. The logic for this has been removed a long time ago, and the SCSS variable should be removed at some point. * Makes the host bindings more clear by expanding the truthy and falsy check.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates the unused landscape row-height variable. The logic for this has been removed a long time ago, and the SCSS variable should be removed at some point.
Makes the host bindings more clear by expanding the truthy and falsy check.