fix(select): blank option label throwing off alignment #11994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes selecting an option that has a blank string as a label throwing off the alignment of `mat-select`. Fixes angular#11969.
googlebot
added
the
cla: yes
jelbourn
reviewed
Jul 11, 2018
| <span class="mat-select-placeholder" *ngSwitchCase="true">{{placeholder || '\u00A0'}}</span> | ||
| <span class="mat-select-value-text" *ngSwitchCase="false" [ngSwitch]="!!customTrigger"> | ||
| <span *ngSwitchDefault>{{triggerValue}}</span> | ||
| <span *ngSwitchDefault>{{triggerValue || '\u00A0'}}</span> |
Member
There was a problem hiding this comment.
Why the escape sequence instead of a space ' '?
Member
Author
There was a problem hiding this comment.
We had a reason for doing it a bit above in the select as well, but I don't remember exactly what it was. I think it's because the browser would still collapse the regular whitespace string.
Contributor
There was a problem hiding this comment.
yeah that's the js equivalent of
victoriaaa234
pushed a commit
that referenced
this pull request
Jul 25, 2018
Fixes selecting an option that has a blank string as a label throwing off the alignment of `mat-select`. Fixes #11969.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes selecting an option that has a blank string as a label throwing off the alignment of
mat-select.Fixes #11969.