fix(overlay): explicitly implement OverlayReference. #11824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`OverlayRef` structurally matches `OverlayReference`, but does not explicitly implement it. That works in TypeScript, and should work in Closure Compiler through the use of `@record`, but for unclear reasons doesn't. Explicitly implementing the interface makes this code clearer, and works around the problem in Closure Compiler while that is being fixed.
googlebot
added
the
cla: yes
crisbeto
added
pr: lgtm
action: merge
Contributor
Author
|
Thanks for the quick review! |
jelbourn
added
the
P1
tinayuangao
pushed a commit
that referenced
this pull request
Jun 26, 2018
`OverlayRef` structurally matches `OverlayReference`, but does not explicitly implement it. That works in TypeScript, and should work in Closure Compiler through the use of `@record`, but for unclear reasons doesn't. Explicitly implementing the interface makes this code clearer, and works around the problem in Closure Compiler while that is being fixed.
victoriaaa234
pushed a commit
that referenced
this pull request
Jul 25, 2018
`OverlayRef` structurally matches `OverlayReference`, but does not explicitly implement it. That works in TypeScript, and should work in Closure Compiler through the use of `@record`, but for unclear reasons doesn't. Explicitly implementing the interface makes this code clearer, and works around the problem in Closure Compiler while that is being fixed.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OverlayRefstructurally matchesOverlayReference, but does notexplicitly implement it. That works in TypeScript, and should work in
Closure Compiler through the use of
@record, but for unclear reasonsdoesn't.
Explicitly implementing the interface makes this code clearer, and works
around the problem in Closure Compiler while that is being fixed.