Skip to content

fix(autofill): listen for animation events outside the zone, but emit… #11798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2018
Merged

fix(autofill): listen for animation events outside the zone, but emit… #11798

merged 1 commit into from
Jun 15, 2018

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Jun 15, 2018

… autofill events inside

@crisbeto looks like #10367 accidentally moved this emit outside of the zone

@mmalerba mmalerba requested review from crisbeto and jelbourn June 15, 2018 07:39
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 15, 2018
@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Jun 15, 2018
crisbeto
crisbeto approved these changes Jun 15, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jun 15, 2018
@jelbourn jelbourn merged commit 48dda50 into master Jun 15, 2018
@mmalerba mmalerba deleted the afm-zone branch July 2, 2018 19:07
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
@mmalerba @victoriaaa234
fix(autofill): listen for animation events outside the zone, but emit…
449bd4f 
… autofill events inside (#11798)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 9, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

@crisbeto crisbeto

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mmalerba @crisbeto @jelbourn @googlebot