fix(overlay): unable to reset overlay size properties to initial value #11592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the consumer not being able to remove the various overlay sizing properties by setting them to null/an empty string, after they're added, without recreating the overlay. Note that these changes would technically let something like `false` through, but these cases will be caught by TS.
googlebot
added
the
cla: yes
jelbourn
reviewed
May 31, 2018
| } | ||
| const style = this._pane.style; | ||
|
|
||
| style.width = coerceCssPixelValue(this._config.width); |
Member
There was a problem hiding this comment.
I think ideally we'd want to use hasOwnProperty here, but we wouldn't be able to do it in a way that works both inside and outside Google due to Closure Compiler's property renaming.
jelbourn
added
pr: lgtm
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Jun 8, 2018
#11592) Fixes the consumer not being able to remove the various overlay sizing properties by setting them to null/an empty string, after they're added, without recreating the overlay. Note that these changes would technically let something like `false` through, but these cases will be caught by TS.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the consumer not being able to remove the various overlay sizing properties by setting them to null/an empty string, after they're added, without recreating the overlay. Note that these changes would technically let something like
falsethrough, but these cases will be caught by TS.