chore: remove internal usages of deprecated APIs #11579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
andrewseguin,
devversion,
jelbourn and
josephperrott
as code owners
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
internal-deprecated-apis-removal
branch
from
c956778 to
9a2278c
Compare
| .toBe(0, `Expected first item of the list to be active.`); | ||
|
|
||
| keyManager.updateActiveItemIndex(1); | ||
| keyManager.setActiveItem(1); |
Member
There was a problem hiding this comment.
It looks like calling setActiveItem has a different effect than updateActiveItemIndex because it looks like this test is failing now
Member
Author
There was a problem hiding this comment.
ops, looks like I replaced it with the wrong method. Should be good to go now.
Removes some internal usages of APIs that we've marked as deprecated, but which have stable equivalents. Doesn't include logic that's in place for backward compatibility.
crisbeto
force-pushed
the
internal-deprecated-apis-removal
branch
from
9a2278c to
cd30c6b
Compare
jelbourn
added
pr: lgtm
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Jun 8, 2018
Removes some internal usages of APIs that we've marked as deprecated, but which have stable equivalents. Doesn't include logic that's in place for backward compatibility.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some internal usages of APIs that we've marked as deprecated, but which have stable equivalents. Doesn't include logic that's in place for backward compatibility.