feat(schematics): address form schematic #11425
Conversation
googlebot
added
the
cla: yes
| margin: 20px auto; | ||
| } | ||
|
|
||
| mat-radio-button { |
There was a problem hiding this comment.
Could this be a css class instead of styling the element directly?
src/lib/schematics/collection.json
Outdated
| "aliases": [ "material-nav" ] | ||
| }, | ||
| // Creates a address form component | ||
| "form": { |
There was a problem hiding this comment.
Should this be something like address-form in case we want to add different forms later?
| <mat-card-title>Shipping Information</mat-card-title> | ||
| </mat-card-header> | ||
| <mat-card-content> | ||
| <table cellspacing="0" class="full-width"> |
There was a problem hiding this comment.
This shouldn't be a table because it's not showing tabular data.
There was a problem hiding this comment.
The other examples used a table so I just carried that over here.
There was a problem hiding this comment.
Which other examples? User-facing ones?
| hasUnitNumber = false; | ||
|
|
||
| states = [ | ||
| { |
There was a problem hiding this comment.
Collapse entries like
{name: 'Alaska', abbreviation: 'AK'},
|
@jelbourn - Addressed feedback. |
jelbourn
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
| <mat-form-field class="full-width"> | ||
| <input matInput placeholder="First name" formControlName="firstName"> | ||
| <mat-error *ngIf="addressForm.controls['firstName'].hasError('required')"> | ||
| First name is <strong>required</strong> |
There was a problem hiding this comment.
nit: you can use addressForm.get('firstName').hasError('required') or even better, IMHO: addressForm.hasError('required', ['firstName']).
jelbourn
added
pr: needs rebase
and removed
action: merge
|
@jelbourn - rebased. |
jelbourn
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
A address form schematic
Demo: https://stackblitz.com/edit/shipping-form