fix(button-toggle): fix button toggle with 0 value not checked #11292
Conversation
googlebot
added
the
cla: yes
tinayuangao
added
target: patch
| if (this.multiple && Array.isArray(this._rawValue)) { | ||
| return !!this._rawValue.find(value => toggle.value != null && value === toggle.value); | ||
| const match = this._rawValue.find(value => toggle.value != null && value === toggle.value); | ||
| return typeof match !== 'undefined'; |
There was a problem hiding this comment.
You should be able to do return match != null, which will capture null and undefined without any of the other falsy values
There was a problem hiding this comment.
Thanks. Updated
tinayuangao
force-pushed
the
fix-button-toggle
branch
from
2564617 to
5ba2f69
Compare
| if (this.multiple && Array.isArray(this._rawValue)) { | ||
| return !!this._rawValue.find(value => toggle.value != null && value === toggle.value); | ||
| const match = this._rawValue.find(value => toggle.value != null && value === toggle.value); | ||
| return match != null; |
There was a problem hiding this comment.
You can just return here: return !!this._rawValue.find(...).
There was a problem hiding this comment.
I found returning !!this._rawValue doesn't work.
Changed to null != this._rawValue.find....
tinayuangao
force-pushed
the
fix-button-toggle
branch
from
5ba2f69 to
eb47e91
Compare
|
|
||
| if (this.multiple && Array.isArray(this._rawValue)) { | ||
| return !!this._rawValue.find(value => toggle.value != null && value === toggle.value); | ||
| return null != this._rawValue.find(value => toggle.value != null && value === toggle.value); |
There was a problem hiding this comment.
If you only care about the presence of the value, you can use some instead of find:
return this._rawValue.some(v => toggle.value != null && v === toggle.value);There was a problem hiding this comment.
Thanks. Updated.
tinayuangao
force-pushed
the
fix-button-toggle
branch
from
eb47e91 to
b5ca77f
Compare
jelbourn
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
Fixes #11279