Skip to content

Conversation

@jelbourn
Copy link
Member

These were broken by rxjs 6.0, but the problem has since been fixed upstream

Overlay and tree still don't work for different reasons.

@jelbourn jelbourn requested review from mmalerba and tinayuangao May 10, 2018 23:31
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 10, 2018
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels May 10, 2018
@ngbot
Copy link

ngbot bot commented May 10, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: build" is failing
    pending status "continuous-integration/travis-ci/pr" is pending
    pending status "branch manager" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba
Copy link
Contributor

actually, looks like the bazel build is broken

@mmalerba mmalerba removed the action: merge The PR is ready for merge by the caretaker label May 10, 2018
@jelbourn
Copy link
Member Author

Had to also update the docker container for circleci

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label May 11, 2018
@ngbot
Copy link

ngbot bot commented May 11, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn jelbourn merged commit ce0040d into angular:master May 11, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants