Skip to content

fix: add custom theme using string ref in angular.json #11189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from May 8, 2018
Merged

fix: add custom theme using string ref in angular.json #11189

merged 1 commit into from May 8, 2018

Conversation

@jerryorta-dev
Copy link
Contributor

@jerryorta-dev jerryorta-dev commented May 6, 2018

Fixes #11188

@jerryorta-dev jerryorta-dev requested a review from amcdnl as a code owner May 6, 2018 17:27
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 6, 2018
amcdnl
amcdnl approved these changes May 6, 2018
View reviewed changes
Copy link
Contributor

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amcdnl amcdnl requested a review from jelbourn May 6, 2018 18:13
jelbourn
jelbourn approved these changes May 7, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels May 7, 2018
@jelbourn jelbourn merged commit 33b5df4 into angular:master May 8, 2018
@jerryorta-dev jerryorta-dev deleted the custom-theme-schematic branch May 8, 2018 18:52
@jerryorta-dev jerryorta-dev restored the custom-theme-schematic branch May 11, 2018 01:52
jelbourn pushed a commit to jelbourn/components that referenced this pull request May 14, 2018
@jerryorta-dev @jelbourn
fix: add custom theme using string ref in angular.json (angular#11189)
f0b1529 
Fixes angular#11188
@beeman beeman mentioned this pull request May 20, 2018
Closed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

+1 more reviewer

@amcdnl amcdnl amcdnl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Schematic does not add custom theme

4 participants

@jerryorta-dev @amcdnl @jelbourn @googlebot