Skip to content

chore: update table examples #11112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2018
Merged

chore: update table examples #11112

merged 1 commit into from
May 9, 2018

Conversation

@andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented May 2, 2018

Updates the table examples to minimize styling and fix some small issues since moving to native table

@andrewseguin andrewseguin requested a review from jelbourn May 2, 2018 21:11
@andrewseguin andrewseguin requested a review from amcdnl as a code owner May 2, 2018 21:11
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 2, 2018
@andrewseguin andrewseguin mentioned this pull request May 2, 2018
Merged
@andrewseguin andrewseguin force-pushed the demo-table-examples branch from 141ab73 to 4b44801 Compare May 2, 2018 21:18
jelbourn
jelbourn reviewed May 2, 2018
View reviewed changes
src/material-examples/cdk-table-basic/cdk-table-basic-example.ts Outdated
};
}
}
const ELEMENT_DATA: Element[] = [
Copy link
Member

@jelbourn jelbourn May 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Element is already a thing, probably don't overload that.

Copy link
Contributor Author

@andrewseguin andrewseguin May 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup agreed - changed to PeriodicElement

@ngbot
Copy link

ngbot bot commented May 3, 2018

Hi @andrewseguin! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@andrewseguin andrewseguin force-pushed the demo-table-examples branch 2 times, most recently from e19bc42 to 35d93af Compare May 8, 2018 16:46
@andrewseguin
Copy link
Contributor Author

andrewseguin commented May 8, 2018

Changed Element to PeriodicElement; rebased and ready for review

jelbourn
jelbourn approved these changes May 8, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
Copy link
Member

jelbourn commented May 8, 2018

@andrewseguin looks like there's a real failure on CI

@andrewseguin andrewseguin force-pushed the demo-table-examples branch from 35d93af to a0df908 Compare May 8, 2018 18:05
@andrewseguin andrewseguin force-pushed the demo-table-examples branch from a0df908 to a54194c Compare May 8, 2018 18:21
@andrewseguin
Copy link
Contributor Author

andrewseguin commented May 8, 2018

All set - CI is happy again.

@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels May 8, 2018
@ngbot
Copy link

ngbot bot commented May 8, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure forbidden label detected: pr: needs*
    failure status "continuous-integration/travis-ci/pr" is failing
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 8, 2018
@ngbot
Copy link

ngbot bot commented May 8, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn jelbourn added target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release and removed target: master only target: patch This PR is targeted for the next patch release labels May 9, 2018
@jelbourn jelbourn merged commit 8c16f01 into angular:master May 9, 2018
@andrewseguin andrewseguin mentioned this pull request May 9, 2018
Closed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@amcdnl amcdnl Awaiting requested review from amcdnl

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewseguin @jelbourn @googlebot