fix(select,autocomplete): mat-option theme not being applied correctly when nested inside a selector #10889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y when nested inside a selector
Fixes the theme for the individual `mat-option` instances producing the wrong selector when it's nested inside a selector, e.g.
```scss
.dark-theme {
@include angular-material-theme($dark-theme);
}
```
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 18, 2018
…es inside a selector
Fixes selector for the disabled dates inside the calendar being wrong, if the theme is scoped under a selector, e.g.
```scss
.dark-theme {
@include angular-material-theme($dark-theme);
}
```
Relates to angular#10889.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 22, 2018
Replaces the `selector-nested-pattern-scoped` Stylelint rule with a new rule called `no-ampersand-beyond-selector-start`. The new rule will enforce that ampersands can only be used at the start of selectors in theme mixins. This will catch issues like angular#10889 and angular#10904 where having an ampersand anywhere else in the selector will work in most cases, but will break down once the mixin is wrapped in a selector.
andrewseguin
pushed a commit
that referenced
this pull request
Apr 26, 2018
…10949) Replaces the `selector-nested-pattern-scoped` Stylelint rule with a new rule called `no-ampersand-beyond-selector-start`. The new rule will enforce that ampersands can only be used at the start of selectors in theme mixins. This will catch issues like #10889 and #10904 where having an ampersand anywhere else in the selector will work in most cases, but will break down once the mixin is wrapped in a selector.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the theme for the individual
mat-optioninstances producing the wrong selector when it's nested inside a selector, e.g.For reference:
