build: add ng_package rule for @angular/material #10625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
requested review from
amcdnl,
andrewseguin,
crisbeto,
devversion,
josephperrott,
kara and
tinayuangao
as code owners
googlebot
added
the
cla: yes
mmalerba
approved these changes
Mar 29, 2018
CaerusKaru
reviewed
Mar 29, 2018
| srcs = glob(["**/*.ts"], exclude=["**/*.spec.ts"]), | ||
| module_name = "@angular/material/divider", | ||
| assets = [":divider_css"], | ||
| assets = [":divider_css"] + glob(["**/*.html"]), |
Member
There was a problem hiding this comment.
Do we need this here since divider has no html files (and likely never will)?
Member
Author
There was a problem hiding this comment.
It's better to have it for consistency with other components; it's just a no-op without any inputs
jelbourn
force-pushed
the
bazel-material-package
branch
from
394cac5 to
2f04bf2
Compare
josephperrott
added
the
target: patch
In order to make this work, this includes: * Move schematics under src/lib * Change sass rules to omit sourcemaps * Add cdk/text-field and lib/tree to packages list * Add bazel rules for prebuilt themes * Add html assets to all ng_module rules * Point all ng_module rules to a package common tsconfig * Add missing index.ts for src/lib * Add bazel rules for schematics * Fix incorrect module_name for hyphenated lib ng_module rules * Add NgModules to `imports` of the example module (formerly were just exports)
jelbourn
force-pushed
the
bazel-material-package
branch
from
2f04bf2 to
f6b50d2
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make this work, this includes:
importsof the example module (formerly were justexports)
However, the rule won't actually succeed until Angular 6.0.0-rc.1 comes out.