Skip to content

Conversation

@crisbeto
Copy link
Member

Fixes a regression that causes a "changed after checked" error to be thrown when there is a button toggle group with an initial value and a set of repeated toggles.

Fixes #10607.

…with a preselected value

Fixes a regression that causes a "changed after checked" error to be thrown when there is a button toggle group with an initial value and a set of repeated toggles.

Fixes angular#10607.
@crisbeto crisbeto added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful pr: needs review labels Mar 29, 2018
@crisbeto crisbeto requested a review from tinayuangao as a code owner March 29, 2018 08:25
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 29, 2018
@mmalerba mmalerba added this to the 6.0 milestone Mar 29, 2018
@josephperrott josephperrott added the target: patch This PR is targeted for the next patch release label Mar 29, 2018
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tinayuangao tinayuangao added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Mar 29, 2018
@josephperrott josephperrott merged commit 9a3d3e8 into angular:master Mar 29, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression in MatButtonToggleGroup causes ExpressionChangedAfterItHasBeenCheckedError

5 participants