Skip to content

fix(select): scroll strategy token cannot inject overlay #10535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2018
Merged

fix(select): scroll strategy token cannot inject overlay #10535

merged 1 commit into from
Mar 23, 2018

Conversation

@jelbourn
Copy link
Member

@jelbourn jelbourn commented Mar 22, 2018

No description provided.

@jelbourn jelbourn requested a review from andrewseguin March 22, 2018 22:02
@jelbourn jelbourn requested review from crisbeto and kara as code owners March 22, 2018 22:02
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 22, 2018
crisbeto
crisbeto approved these changes Mar 22, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 22, 2018
@josephperrott josephperrott added the target: patch This PR is targeted for the next patch release label Mar 23, 2018
@jelbourn jelbourn force-pushed the select-provider-fix branch from cb1f259 to 29b656c Compare March 23, 2018 17:41
@andrewseguin andrewseguin merged commit 3eb71c2 into angular:master Mar 23, 2018
@jelbourn jelbourn deleted the select-provider-fix branch April 2, 2018 22:32
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@kara kara Awaiting requested review from kara

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jelbourn @crisbeto @googlebot @josephperrott @andrewseguin