Skip to content

docs(form-field): add docs for appearance and mention that color type is supported #10274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2018
Merged

docs(form-field): add docs for appearance and mention that color type is supported #10274

merged 2 commits into from
Mar 12, 2018

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Mar 5, 2018

Adds docs for some of the issues mentioned in #10222

@mmalerba mmalerba added pr: needs review docs This issue is related to documentation target: major This PR is targeted for the next major release labels Mar 5, 2018
@mmalerba mmalerba added this to the 6.0 milestone Mar 5, 2018
@mmalerba mmalerba requested a review from jelbourn March 5, 2018 22:55
@mmalerba mmalerba requested a review from amcdnl as a code owner March 5, 2018 22:55
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 5, 2018
jelbourn
jelbourn approved these changes Mar 5, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Mar 5, 2018
@mmalerba mmalerba merged commit 9403ead into angular:master Mar 12, 2018
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@amcdnl amcdnl Awaiting requested review from amcdnl

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: major This PR is targeted for the next major release

Projects

None yet

Milestone

6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mmalerba @jelbourn @googlebot