Skip to content

fix(select, autocomplete): no indication of active option in high contrast mode #10229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2018
Merged

fix(select, autocomplete): no indication of active option in high contrast mode #10229

merged 1 commit into from
Mar 6, 2018

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 2, 2018

Fixes users in high contrast mode not being able to distinguish the active option from all the other options.

Fixes #10207.

@crisbeto crisbeto added pr: needs review Accessibility This issue is related to accessibility (a11y) labels Mar 2, 2018
@crisbeto crisbeto requested a review from kara as a code owner March 2, 2018 06:13
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 2, 2018
jelbourn
jelbourn approved these changes Mar 2, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Mar 2, 2018
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Mar 2, 2018
@crisbeto crisbeto force-pushed the 10207/option-high-contrast-a11y branch from e47b36f to 5620729 Compare March 2, 2018 19:23
@crisbeto
fix(select, autocomplete): no indication of active option in high con…
ae02aee 
…trast mode.

Fixes users in high contrast mode not being able to distinguish the active option from all the other options.

Fixes angular#10207.
@crisbeto crisbeto force-pushed the 10207/option-high-contrast-a11y branch from 5620729 to ae02aee Compare March 2, 2018 21:06
@jelbourn jelbourn merged commit be0f17e into angular:master Mar 6, 2018
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@kara kara Awaiting requested review from kara

Assignees

@jelbourn jelbourn

Labels

Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

a11y - mat-option does not have a focus indicator when active in high contrast mode

3 participants

@crisbeto @jelbourn @googlebot