Skip to content

chore: bump to 6.0.0-beta.6 and remove explicit preserveWhitespaces setting #10216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2018
Merged

chore: bump to 6.0.0-beta.6 and remove explicit preserveWhitespaces setting #10216

merged 1 commit into from
Mar 6, 2018

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 1, 2018

  • Bumps the Angular version to at least 6.0.0-beta.6.
  • Removes all of the preserveWhitespaces declarations, because the option is now false by default.
  • Removes the tslint requirement for preserveWhitespaces.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 1, 2018
@crisbeto
chore: bump to 6.0.0-beta.6 and remove explicit preserveWhitespaces s…
02d5736 
…etting

* Bumps the Angular version to at least 6.0.0-beta.6.
* Removes all of the `preserveWhitespaces` declarations, because the option is now `false` by default.
* Removes the tslint requirement for `preserveWhitespaces`.
@crisbeto crisbeto force-pushed the preserve-whitespaces-no-more branch from 0ae9418 to 02d5736 Compare March 2, 2018 21:05
amcdnl
amcdnl approved these changes Mar 4, 2018
View reviewed changes
Copy link
Contributor

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added pr: lgtm target: major This PR is targeted for the next major release and removed pr: needs review labels Mar 5, 2018
jelbourn
jelbourn approved these changes Mar 5, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Mar 5, 2018
@jelbourn jelbourn merged commit 8830486 into angular:master Mar 6, 2018
@rafaelss95 rafaelss95 mentioned this pull request Apr 8, 2018
Merged
@devversion devversion mentioned this pull request Jul 6, 2018
Merged
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@devversion devversion Awaiting requested review from devversion

@josephperrott josephperrott Awaiting requested review from josephperrott

@kara kara Awaiting requested review from kara

@tinayuangao tinayuangao Awaiting requested review from tinayuangao

+1 more reviewer

@amcdnl amcdnl amcdnl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@crisbeto @amcdnl @jelbourn @mmalerba @googlebot