Skip to content

Don't implement FirebaseApp, this leads to fragility (requires Firebase 5.0.2) #1630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Don't implement FirebaseApp, this leads to fragility (requires Firebase 5.0.2) #1630

wants to merge 2 commits into from

Conversation

@jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented May 12, 2018 •
edited
Loading

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

Depends on #1628

Code sample

@jamesdaniels jamesdaniels changed the title Don't implement FirebaseApp, this leads to fragility Don't implement FirebaseApp, this leads to fragility (requires Firebase 5.0.2) May 12, 2018
@jamesdaniels jamesdaniels requested a review from davideast May 12, 2018 01:40
@jamesdaniels
Copy link
Member Author

jamesdaniels commented May 12, 2018

Hopefully the bangs won't be needed much longer, seems to have attention in the JS SDK firebase/firebase-js-sdk#793

@jamesdaniels jamesdaniels changed the title Don't implement FirebaseApp, this leads to fragility (requires Firebase 5.0.2) WIP Don't implement FirebaseApp, this leads to fragility (requires Firebase 5.0.2) May 12, 2018
davideast
davideast approved these changes May 12, 2018
View reviewed changes
Copy link
Collaborator

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesdaniels jamesdaniels changed the title WIP Don't implement FirebaseApp, this leads to fragility (requires Firebase 5.0.2) Don't implement FirebaseApp, this leads to fragility (requires Firebase 5.0.2) May 12, 2018
@jamesdaniels
Copy link
Member Author

jamesdaniels commented May 12, 2018

Darn, looks like I missed up something in the merge; will address.

@jamesdaniels
Copy link
Member Author

jamesdaniels commented May 12, 2018

Going to close for now, having trouble with the exports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davideast davideast davideast approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jamesdaniels @davideast @googlebot