Skip to content

Edit doc for sample code may cause confusion #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 13, 2017
Merged

Edit doc for sample code may cause confusion #1260

merged 3 commits into from
Oct 13, 2017

Conversation

@adnan333bd
Copy link
Contributor

@adnan333bd adnan333bd commented Oct 13, 2017

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, npm install, npm run build, and npm test run successfully? (yes/no; required)

Description

Code sample

@jamesdaniels jamesdaniels merged commit 2ff8d1d into angular:master Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adnan333bd @jamesdaniels @googlebot