This repository was archived by the owner on Dec 4, 2017. It is now read-only.
chore: remove bootstrap package #2691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I agree with this approach. I creatd and merged companion PR #270 in angular/quickstart |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason behind this change is to not confuse the end user with "Why do we have bootstrap as a dependency"? "Does Angular depend on bootstrap"?
The idea was to replicate the minimum css needed from bootstrap into those two forms guides but I think it is better for the time being to use a cdn (I saw that phonecat, AKA upgrade guide uses a cdn with bootstrap already) and then change it later.