fix(@ngtools/webpack): always emit on first build #7933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
force-pushed
the
fix-error-emit
branch
6 times, most recently
from
fb4d376 to
58acf2f
Compare
hansl
previously approved these changes
Oct 5, 2017
We want to allow emitting with errors on the first run so that imports can be added to the webpack dependency tree and rebuilds triggered by file edits. This will not cause webpack to finish the compilation successfully on error, it will just allow it to follow imports. Fix angular#7890
filipesilva
force-pushed
the
fix-error-emit
branch
from
58acf2f to
25dba83
Compare
Brocco
approved these changes
Oct 5, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to allow emitting with errors on the first run so that imports can be added to the webpack dependency tree and rebuilds triggered by file edits.
This will not cause webpack to finish the compilation successfully on error, it will just allow it to follow imports.
Fix #7890