refactor(@angular/build): optimize Vitest in-memory plugin resolveId #31858
Conversation
Refactors the `resolveId` hook in the `angular:test-in-memory-provider` Vite plugin to improve clarity, efficiency, and cross-platform consistency. Key improvements include: - Consolidating path resolution logic into a single flow. - Ensuring all resolved paths are absolute and consistently POSIX-formatted. - Prioritizing direct test entry point lookups. - Removing redundant checks and assertions.
This commit optimizes the 'angular:test-in-memory-provider' Vitest plugin by introducing a 'loadResultFile' helper. This helper utilizes 'TextDecoder' to decode memory files, avoiding unnecessary buffer copies associated with 'Buffer.from().toString()'. It also removes duplicate file reading logic for source maps.
clydin
added
the
action: review
clydin
removed
the
action: review
|
I see that you just added the |
alan-agius4
added
action: merge
|
I see that you just added the |
4 participants
Refactors the
resolveIdhook in theangular:test-in-memory-providerVite plugin to improve clarity, efficiency, and cross-platform consistency. Also optimizes the plugin by introducing a 'loadResultFile' helper. This helper utilizes 'TextDecoder' to decode memory files, avoiding unnecessary buffer copies associated with 'Buffer.from().toString()'. It also removes duplicate file reading logic for source maps.