Skip to content

Conversation

@clydin
Copy link
Member

@clydin clydin commented Jul 3, 2024

The isolated modules transpilation option that was recently introduced is currently disabled when source maps are enabled. TypeScript has two mutually exclusive options that can be used to check for source map usage. Both of these options (sourceMap and inlineSourceMap) are now checked to determine if the direct transpilation optimization can be used.

…es optimization

The isolated modules transpilation option that was recently introduced is
currently disabled when source maps are enabled. TypeScript has two mutually
exclusive options that can be used to check for source map usage. Both of
these options (`sourceMap` and `inlineSourceMap`) are now checked to determine
if the direct transpilation optimization can be used.
@clydin clydin added the target: rc This PR is targeted for the next release-candidate label Jul 3, 2024
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 3, 2024
@clydin clydin requested a review from alan-agius4 July 3, 2024 17:10
@alan-agius4 alan-agius4 added action: presubmit The PR is in need of a google3 presubmit action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: presubmit The PR is in need of a google3 presubmit labels Jul 3, 2024
@clydin clydin merged commit aa88e68 into angular:main Jul 3, 2024
@clydin
Copy link
Member Author

clydin commented Jul 3, 2024

The changes were merged into the following branches: main, 18.1.x

@clydin clydin deleted the application/isolated-inline-sourcemaps branch July 3, 2024 17:31
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants