fix(@schematics/angular): add missing icons in ng-new template #26259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
alan-agius4
force-pushed
the
missing-icons
branch
2 times, most recently
from
80ce09e to
d9f9dfe
Compare
|
Should we also update the favicon to be the new logo? |
twerske
approved these changes
Nov 7, 2023
packages/schematics/angular/application/files/common-files/src/app/app.component.html.template
Outdated
Show resolved
Hide resolved
alan-agius4
force-pushed
the
missing-icons
branch
2 times, most recently
from
1a5365d to
4bd0141
Compare
JoostK
reviewed
Nov 7, 2023
packages/schematics/angular/application/files/common-files/src/app/app.component.html.template
Outdated
Show resolved
Hide resolved
alan-agius4
force-pushed
the
missing-icons
branch
from
bf93e33 to
df75696
Compare
This commit adds a number of missing icons. Closes angular#26257
This commit replaces the Angular old logo with the new one.
alan-agius4
force-pushed
the
missing-icons
branch
from
5aa9e97 to
de0966f
Compare
dgp1130
approved these changes
Nov 7, 2023
packages/schematics/angular/application/files/common-files/src/app/app.component.html.template
Outdated
Show resolved
Hide resolved
packages/schematics/angular/application/files/common-files/src/app/app.component.html.template
Outdated
Show resolved
Hide resolved
This commit uses control flow to reduces code in the template
Only h1 is used in the initial template.
alan-agius4
force-pushed
the
missing-icons
branch
from
de0966f to
a7855e3
Compare
Just in case Inter Tight is not available.
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a number of missing icons.
Closes #26257