fix(@angular-devkit/build-angular): handle HTTP requests to assets during prerendering #26117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
alan-agius4
force-pushed
the
prerender-server
branch
2 times, most recently
from
b396ce4 to
c95cb37
Compare
clydin
reviewed
Oct 25, 2023
packages/angular_devkit/build_angular/src/utils/server-rendering/prerender-server.ts
Outdated
Show resolved
Hide resolved
clydin
approved these changes
Oct 25, 2023
alan-agius4
force-pushed
the
prerender-server
branch
from
c95cb37 to
dfdef03
Compare
alan-agius4
added
action: merge
alan-agius4
force-pushed
the
prerender-server
branch
3 times, most recently
from
143a608 to
f7d9a41
Compare
…ring prerendering This commit fixes an issue were during prerendering (SSG) http requests to assets causes prerendering to fail. Closes angular#25720
alan-agius4
force-pushed
the
prerender-server
branch
from
f7d9a41 to
1b10b15
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue were during prerendering (SSG) http requests to assets causes prerendering to fail.
Closes #25720