Skip to content

Conversation

@alan-agius4
Copy link
Collaborator

This commits updates the ssr application builder option definition. The main change is that now the option does not accept the entry-point as a value. Instead it should be passed in the entry suboption.

Example

"ssr": {
    "entry": "server.ts"
}

This change in this option is important to allow us in the future to add additional sub options. Like potentially a platform or target.

@alan-agius4 alan-agius4 added this to the v17 milestone Oct 19, 2023
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels Oct 19, 2023
@alan-agius4 alan-agius4 requested a review from clydin October 19, 2023 07:17
This commits updates the `ssr` application builder option definition. The main change is that now the option does not accept the entry-point as a value. Instead it should be passed in the `entry` suboption.

Example
```json
"ssr": {
    "entry": "server.ts"
}
```

This change in this option is important to allow us in the future to add additional sub options. Like potentially a `platform` or `target`.
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 19, 2023
@alan-agius4 alan-agius4 merged commit 17fd0ad into angular:main Oct 19, 2023
@alan-agius4 alan-agius4 deleted the add-server-entry branch October 19, 2023 11:15
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants