Skip to content

Conversation

@clydin
Copy link
Member

@clydin clydin commented Oct 11, 2023

Similar to the existing Webpack-based browser builder, the new application builder is also exported from the @angular-devkit/build-angular package for use programmatically. As is the case for the existing builder JavaScript exports from the package, the new export (buildApplication) is also considered experimental and does not provide the support nor semver guarantees that the builders have when used via angular.json configuration. The usage of the plugins parameter of the buildApplication allows adding esbuild compatible plugins to the end of the plugin list for the main application code bundling. However, usage of the parameter may result in unexpected application output and/or build failures. Stable and supported methods for build process extension are being evaluated for a future release.

Closes #25556 and closes #24163

@clydin clydin added the target: major This PR is targeted for the next major release label Oct 11, 2023
@clydin clydin added this to the v17 milestone Oct 11, 2023
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clydin clydin marked this pull request as ready for review October 11, 2023 14:28
…or experimental programmatic usage

Similar to the existing Webpack-based `browser` builder, the new `application` builder is also exported
from the `@angular-devkit/build-angular` package for use programmatically. As is the case for the existing
builder JavaScript exports from the package, the new export (`buildApplication`) is also considered experimental
and does not provide the support nor semver guarantees that the builders have when used via `angular.json` configuration.
The usage of the `plugins` parameter of the `buildApplication` allows adding esbuild compatible plugins to the end
of the plugin list for the main application code bundling. However, usage of the parameter may result in unexpected application
output and/or build failures. Stable and supported methods for build process extension are being evaluated for a future release.
@clydin clydin force-pushed the esbuild/experimental-plugins branch from b387963 to 08ac65c Compare October 11, 2023 15:03
@clydin clydin added the action: merge The PR is ready for merge by the caretaker label Oct 11, 2023
@alan-agius4 alan-agius4 merged commit c74e618 into angular:main Oct 11, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release

Projects

None yet

2 participants