fix(@angular-devkit/build-angular): only add @angular/platform-server/init when package is installed.
#24191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: rc
alan-agius4
force-pushed
the
server-init-server
branch
from
341005b to
f012a07
Compare
alan-agius4
added
the
action: review
clydin
approved these changes
Nov 7, 2022
packages/angular_devkit/build_angular/src/builders/server/index.ts
Outdated
Show resolved
Hide resolved
alan-agius4
added
action: merge
…r/init` when package is installed. This commit fixes an issue where `@angular/platform-server/init` was added as an entry-point during the server build even when this was not installed. Closes angular#24188
alan-agius4
force-pushed
the
server-init-server
branch
from
f012a07 to
c2dad5c
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where
@angular/platform-server/initwas added as an entry-point during the server build even when this was not installed.Closes #24188