revert skipLibCheck #16786

alan-agius4 · 2020-01-29T07:34:57Z

Following a convo with @DanielRosenwasser we decided to revert this change.

More context: #16696

Closes #16696

…ests workspace tsconfig" This reverts commit 3ae1eb6.

…config" This reverts commit a8c60cb. Closes: #16696

This reverts commit aadf779.

alan-agius4 · 2020-01-29T07:35:26Z

angular-automatic-lock-bot · 2020-02-29T08:03:54Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

_{This action has been performed automatically by a bot.}

alan-agius4 added 3 commits January 29, 2020 08:31

revert: "test(@angular-devkit/build-angular): add skipLibCheck to t…

2d07598

…ests workspace tsconfig" This reverts commit 3ae1eb6.

revert: "fix(@schematics/angular): add skipLibCheck to workspace ts…

e39edb9

…config" This reverts commit a8c60cb. Closes: #16696

revert: "test: add e2e test to test disabled skipLibCheck"

9e4ff3e

This reverts commit aadf779.

googlebot added the cla: yes label Jan 29, 2020

alan-agius4 added the target: patch This PR is targeted for the next patch release label Jan 29, 2020

alan-agius4 requested a review from filipesilva January 29, 2020 07:35

filipesilva approved these changes Jan 29, 2020

View reviewed changes

alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jan 29, 2020

kyliau merged commit 9e3117d into angular:master Jan 29, 2020

alan-agius4 deleted the skip-lib-revert branch January 29, 2020 19:08

angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 29, 2020

Provide feedback