Clean up Build Optimizer whitelists #15239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gular classes This whitelist a leftover from older Angular versions and isn't necessary anymore. Fix angular#15194
filipesilva
added
the
target: major
…ar/core` We used to keep a specifier list of known specifiers to identify the `@angular/core` FESM. But it doesn't work for non-FESM bundles, and we already pass that information on anyway.
filipesilva
force-pushed
the
bo-platform-whitelist
branch
from
0f3c7ce to
e366cee
Compare
clydin
approved these changes
Aug 2, 2019
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Aug 7, 2019
…re files to be metadata too Followup to angular#15239, fixes a 6kb size regression in new apps, potentially more in larger apps. Local declarations inside `@angular/core` files should also be considered metadata and scrubbed.
kyliau
pushed a commit
that referenced
this pull request
Aug 8, 2019
…re files to be metadata too Followup to #15239, fixes a 6kb size regression in new apps, potentially more in larger apps. Local declarations inside `@angular/core` files should also be considered metadata and scrubbed.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15194