Ivy libraries and workspace #15186

alan-agius4 · 2019-07-29T08:49:33Z

feat(@schematics/angular): introduce Ivy workspace concept

At the moment, to enable Ivy as the view rendering engine we are adding enableIvy: true in each of the applications tsconfigs.
While this works this is not ideal when users want to opt-out, as users will need to modify multiple tsconfig.

With the introduction of Ivy libraries for development this will be even harder and cumbersome.

We added the enableIvy option to the workspace schematic and remove the option for the application schematic.

ng new <project-name> --enable-ivy will pass down down the option the workspace schematic and an Ivy workspace will be created.
Other schematics such as application and library will read the workspace (root) tsconfig to verify if a application or library with
Ivy structure and configuration should be created.

feat(@schematics/angular): introduce Ivy libraries for development

Since NGCC is non incremental and in library projects we have the original TS sources
we don't need to build a library using the VE and transform it using NGCC. Instead we can build the library using NGTSC (Ivy) directly
as this enables faster incremental compilations and a better development experience.

Libraries now have a production configuration, which enabled VE compilations. As it is not recommended to publish NGTSC (Ivy)
built libraries to NPM repositories, since Ivy libraries are not backwards compatible with the legacy View Engine.

feat(@schematics/angular): ivy library migration

Add a migration to migrate existing libraries to the new library layout considering it will be the default in version 9.

alan-agius4 · 2019-07-29T08:58:29Z

packages/schematics/angular/application/schema.json

@@ -19,12 +19,6 @@
      },
      "x-prompt": "What name would you like to use for the application?"
    },
-    "enableIvy": {


Since this is experimental, I don't think we need to deprecate.

Yeah I think that's ok.

Don't we still need this option? The migration won't run until 9 so the option won't be at the root tsconfig yet.

alan-agius4 · 2019-07-29T09:00:08Z

docs/design/analytics.md

@@ -48,7 +48,6 @@ Note: There's a limit of 20 custom dimensions.
 | 5 | `Flag: --style` | `string` |
 | 6 | `--collection` | `string` |
 | 7 | `--buildEventLog` | `boolean` |
-| 8 | `Flag: --enableIvy` | `boolean` |


Need to inform @StephenFluin about this, if we are going to remove it.

I think we want to keep it to see if users are opting out on project creation.

But the flag itself no longer exists on ng generate application, hence there is no data to collect.

enableIvy exists on ng new and ng generate workspace

Yes, that's true. This file doesn't mention anything about what commands capture it though.

yeah, I will add this to ng-new to that this matrix is captured there.

https://github.com/angular/angular-cli/pull/15186/files#diff-e1a844356231f48df29c54e39fcb9951R25

alan-agius4 · 2019-07-29T13:47:14Z

@filipesilva, we should have some documentation on AIO and make it clearer not to publish Ivy libraries to NPM.

filipesilva

Just a minor comment and a test request, everything else looks good. Great work!

filipesilva · 2019-07-30T09:55:18Z

docs/design/analytics.md

@@ -48,7 +48,6 @@ Note: There's a limit of 20 custom dimensions.
 | 5 | `Flag: --style` | `string` |
 | 6 | `--collection` | `string` |
 | 7 | `--buildEventLog` | `boolean` |
-| 8 | `Flag: --enableIvy` | `boolean` |


I think we want to keep it to see if users are opting out on project creation.

packages/angular_devkit/build_ng_packagr/src/build/index_spec_large.ts

At the moment, to enable Ivy as the view rendering engine we are adding `enableIvy: true` in each of the applications tsconfigs. While this works this is not ideal when users want to opt-out, as users will need to modify multiple tsconfig. With the introduction of Ivy libraries for development this will be even harder and cumbersome. We added the `enableIvy` option to the `workspace` schematic and remove the option for the `application` schematic. `ng new <project-name> --enable-ivy` will pass down down the option the workspace schematic and an Ivy workspace will be created. Other schematics such as `application` and `library` will read the workspace (root) tsconfig to verify if a application or library with Ivy structure and configuration should be created.

Since `NGCC` is non incremental and in library projects we have the original TS sources we don't need to build a library using the `VE` and transform it using `NGCC`. Instead we can build the library using `NGTSC` (Ivy) directly as this enables faster incremental compilations and a better development experience. Libraries now have a `production` configuration, which enabled `VE` compilations. As it is not recommended to publish NGTSC (Ivy) built libraries to NPM repositories, since Ivy libraries are not backwards compatible with the legacy View Engine.

Add a migration to migrate existing libraries to the new library layout considering it will be the default in version 9.

Previously, we were not testing web workers under Ivy as we were overriding tsconfig.app.json entirely without including enableIvy. When enabling Ivy we are getting warning of files that are part of the compilation which causing a warning to show and break the test.

clydin · 2019-07-30T14:54:18Z

packages/schematics/angular/application/schema.json

@@ -19,12 +19,6 @@
      },
      "x-prompt": "What name would you like to use for the application?"
    },
-    "enableIvy": {


Don't we still need this option? The migration won't run until 9 so the option won't be at the root tsconfig yet.

clydin · 2019-07-30T15:00:59Z

packages/schematics/angular/utility/workspace.ts

+ * Returns `true` when the workspace root tsconfig is set to use Ivy
+ * as the Angular rendering engine.
+ */
+export function isIvyWorkspace(tree: Tree): boolean {


I'm not sure this is the correct file for this function since its not related to reading/writing the workspace file.

The function will also not handle extended configurations which would make it problematic to generate an application with ivy enabled in such a scenario.

Is it common to have extended root level tsconfig? (Not application specific)? Example. /tsconfig.json extends /tsconfig.base.json, pretty much in our schematics we only handle /tsconfig.json as a base for other tsconfigs.

Re the file, any thoughts were it so go?

alan-agius4 · 2019-07-30T17:01:26Z

@clydin

Don't we still need this option? The migration won't run until 9 so the option won't be at the root tsconfig yet.

No it's not needed any more, since now we have the concept of an ivy workspace instead of an Ivy application.

Though that is a good question about existing workspaces which are not Ivy but want to generate an Ivy application. Should this be supported?

//cc @filipesilva

clydin · 2019-07-30T17:03:39Z

There's also the situation of existing ivy generated workspaces that are not configured as ivy workspaces.

filipesilva · 2019-08-02T15:05:37Z

I think it's not a deal breaker if people have to manually set enableIvy. Realistically speaking you don't make apps/libs very often. And when you do, you mostly want to use the same compiler. I don't think many people would have to set it manually.

alan-agius4 · 2019-08-13T09:45:48Z

Superseded by #15320

angular-automatic-lock-bot · 2019-09-13T07:41:02Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Jul 29, 2019

alan-agius4 commented Jul 29, 2019

View reviewed changes

alan-agius4 requested a review from filipesilva July 29, 2019 11:39

alan-agius4 added the target: major This PR is targeted for the next major release label Jul 29, 2019

alan-agius4 marked this pull request as ready for review July 29, 2019 12:07

filipesilva suggested changes Jul 30, 2019

View reviewed changes

alan-agius4 added 8 commits July 30, 2019 13:35

build: update ng-packagr to ^5.4.0

125a08a

feat(@schematics/angular): ivy library migration

20fe005

Add a migration to migrate existing libraries to the new library layout considering it will be the default in version 9.

test: update Ivy tests as per new workspace settings

2724797

test: update ng-packagr builder tests to work on Windows

71c5512

build: add ng packagr test large for ivy

e2d79c6

filipesilva approved these changes Jul 30, 2019

View reviewed changes

clydin requested changes Jul 30, 2019

View reviewed changes

alan-agius4 added the needs: discussion On the agenda for team meeting to determine next steps label Jul 30, 2019

alan-agius4 added state: blocked and removed needs: discussion On the agenda for team meeting to determine next steps labels Aug 8, 2019

alan-agius4 closed this Aug 13, 2019

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019

Ivy libraries and workspace #15186

Ivy libraries and workspace #15186

Uh oh!

Conversation

alan-agius4 commented Jul 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alan-agius4 commented Jul 29, 2019

Uh oh!

filipesilva left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alan-agius4 Jul 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alan-agius4 commented Jul 30, 2019

Uh oh!

clydin commented Jul 30, 2019

Uh oh!

filipesilva commented Aug 2, 2019

Uh oh!

alan-agius4 commented Aug 13, 2019

Uh oh!

angular-automatic-lock-bot bot commented Sep 13, 2019

Uh oh!

Uh oh!

alan-agius4 commented Jul 29, 2019 •

edited

Loading

alan-agius4 Jul 30, 2019 •

edited

Loading