test: add 7.0 update test #14228
Merged
test: add 7.0 update test #14228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
commented
Apr 22, 2019
filipesilva
commented
Apr 22, 2019
filipesilva
commented
Apr 22, 2019
filipesilva
force-pushed
the
lazy-route-migration-e2e
branch
from
3308457 to
b55c362
Compare
filipesilva
commented
Apr 22, 2019
filipesilva
commented
Apr 22, 2019
filipesilva
force-pushed
the
lazy-route-migration-e2e
branch
from
b55c362 to
9168b24
Compare
filipesilva
commented
Apr 22, 2019
filipesilva
force-pushed
the
lazy-route-migration-e2e
branch
from
9168b24 to
e15fc82
Compare
filipesilva
force-pushed
the
lazy-route-migration-e2e
branch
from
e15fc82 to
45c5e14
Compare
filipesilva
commented
Apr 22, 2019
filipesilva
force-pushed
the
lazy-route-migration-e2e
branch
from
45c5e14 to
822ce86
Compare
filipesilva
commented
Apr 22, 2019
| `loadChildren: () => import('./lazy/lazy.module').then(m => m.LazyModule)`); | ||
| // Unnecessary es6 polyfills should be removed via drop-es6-polyfills. | ||
| await expectToFail(() => expectFileToMatch('src/polyfills.ts', `import 'core-js/es6/symbol';`)); | ||
| await expectToFail(() => expectFileToMatch('src/polyfills.ts', `import 'core-js/es6/set';`)); |
filipesilva
force-pushed
the
lazy-route-migration-e2e
branch
from
822ce86 to
69761dd
Compare
norawis
approved these changes
Apr 23, 2019
filipesilva
force-pushed
the
lazy-route-migration-e2e
branch
5 times, most recently
from
b960bbb to
7a5955c
Compare
filipesilva
force-pushed
the
lazy-route-migration-e2e
branch
from
7a5955c to
a8e33c1
Compare
filipesilva
added
the
target: major
clydin
approved these changes
Apr 24, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.