Skip to content

Fully resolve correct @ngtools/webpack loader #13549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2019

Conversation

clydin
Copy link
Member

@clydin clydin commented Jan 30, 2019

By using the the direct import approach, the loader will be guaranteed to originate from the same package version/location as the other @ngtools/webpack imports (AngularCompilerPlugin for instance).

Fixes #13539

…sion

By using the the direct import approach, the loader will be guaranteed to originate from the same package version/location as the other `@ngtools/webpack` imports.

Fixes angular#13539
@clydin clydin added the target: patch This PR is targeted for the next patch release label Jan 30, 2019
@clydin clydin requested a review from filipesilva January 30, 2019 20:38
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is much better. I wonder why we didn't do that in the first place.

@fabianbru
Copy link

I can confirm, that my problem from #13539 in my application is fixed with this PR.

@vikerman vikerman merged commit fa6795a into angular:master Feb 6, 2019
vikerman pushed a commit that referenced this pull request Feb 6, 2019
* refactor(@ngtools/webpack): support import-based loader resolution

* fix(@angular-devkit/build-angular): ensure correct ngtools loader version

By using the the direct import approach, the loader will be guaranteed to originate from the same package version/location as the other `@ngtools/webpack` imports.

Fixes #13539
@clydin clydin deleted the fix-ngtools-loader branch February 6, 2019 15:25
@krimple
Copy link

krimple commented Feb 20, 2019

Question - do we need to upgrade our CLI to 8.x beta in order to get monorepo builds to work again, or downgrade to a version that isn't broken? Please advise, I only see this fix attached to an 8.x beta.

@filipesilva
Copy link
Contributor

@krimple this should be in the next patch version of 7.x too.

@krimple
Copy link

krimple commented Feb 20, 2019

Is that more than a week away? Was making progress on my project but am stopped and can't figure out how to back off of this - if I downgrade ngtools to 7.3.1 or 7.2.x it complains about the version of typescript. I downgrade typescript and still get an error that I have the wrong version.

Just not sure how to get back to a usable tool chain with an existing project.

Thanks, sorry for bugging you but this is a confusing area to troubleshoot.

Ken

@filipesilva
Copy link
Contributor

We usually do releases every thursday, but there is some variance at times. There should be a release every week or so.

@krimple
Copy link

krimple commented Feb 20, 2019 via email

@filipesilva
Copy link
Contributor

@krimple actually, was looking at the commits in the patch branch (https://github.com/angular/angular-cli/commits/7.3.x), and I see this is released on 7.3.1+ already. So if you use @angular-devkit/[email protected] (the matching version of the build system) you should get it.

@krimple
Copy link

krimple commented Feb 21, 2019 via email

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't resolve '@ngtools/webpack' in yarn monorepo
6 participants