-
Notifications
You must be signed in to change notification settings - Fork 12k
Fully resolve correct @ngtools/webpack
loader
#13549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…sion By using the the direct import approach, the loader will be guaranteed to originate from the same package version/location as the other `@ngtools/webpack` imports. Fixes angular#13539
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is much better. I wonder why we didn't do that in the first place.
I can confirm, that my problem from #13539 in my application is fixed with this PR. |
* refactor(@ngtools/webpack): support import-based loader resolution * fix(@angular-devkit/build-angular): ensure correct ngtools loader version By using the the direct import approach, the loader will be guaranteed to originate from the same package version/location as the other `@ngtools/webpack` imports. Fixes #13539
Question - do we need to upgrade our CLI to 8.x beta in order to get monorepo builds to work again, or downgrade to a version that isn't broken? Please advise, I only see this fix attached to an 8.x beta. |
@krimple this should be in the next patch version of 7.x too. |
Is that more than a week away? Was making progress on my project but am stopped and can't figure out how to back off of this - if I downgrade ngtools to 7.3.1 or 7.2.x it complains about the version of typescript. I downgrade typescript and still get an error that I have the wrong version. Just not sure how to get back to a usable tool chain with an existing project. Thanks, sorry for bugging you but this is a confusing area to troubleshoot. Ken |
We usually do releases every thursday, but there is some variance at times. There should be a release every week or so. |
Ok, I can work around it. I'll just revert back to an earlier build with an
older yarn.lock file set.
Thanks again,
Ken
Ken Rimple
Training and Mentoring Services
Chariot Solutions
610-608-3935
@RimpleOnTech
…On Wed, Feb 20, 2019 at 3:50 PM Filipe Silva ***@***.***> wrote:
We usually do releases every thursday, but there is some variance at
times. There should be a release every week or so.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13549 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAQloIbNnmHyBMqO8GNT1rUFjQilK_aks5vPbUigaJpZM4abAJ6>
.
|
@krimple actually, was looking at the commits in the patch branch (https://github.com/angular/angular-cli/commits/7.3.x), and I see this is released on 7.3.1+ already. So if you use |
Great. Thanks.
…Sent from my iPhone
On Feb 21, 2019, at 3:46 AM, Filipe Silva ***@***.***> wrote:
@krimple actually, was looking at the commits in the patch branch (https://github.com/angular/angular-cli/commits/7.3.x), and I see this is released on 7.3.1+ already. So if you use @***@***.*** (the matching version of the build system) you should get it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
By using the the direct import approach, the loader will be guaranteed to originate from the same package version/location as the other
@ngtools/webpack
imports (AngularCompilerPlugin for instance).Fixes #13539