Skip to content

$destroy event is triggered before animation ends #2346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2015
Merged

$destroy event is triggered before animation ends #2346

merged 1 commit into from
Oct 30, 2015

Conversation

@Teemu
Copy link
Contributor

@Teemu Teemu commented Oct 30, 2015

closes #1643

@Teemu Teemu changed the title fix(viewDirective): $destroy event is triggered before animation ends $destroy event is triggered before animation ends Oct 30, 2015
fix(viewDirective): $destroy event is triggered before animation ends
1be1379 
when view is animated using ngAnimate, $destroy event is triggered before
animation ends.

closes angular-ui#1643
@Teemu Teemu force-pushed the destroy-event-triggered-before-animation-ends branch from 02cb293 to 1be1379 Compare October 30, 2015 12:56
@nateabele
Copy link
Contributor

nateabele commented Oct 30, 2015

@Frozenball Pro.

nateabele added a commit that referenced this pull request Oct 30, 2015
@nateabele
Merge pull request #2346 from fastmonkeys/destroy-event-triggered-bef…
db79d76 
…ore-animation-ends

$destroy event is triggered before animation ends
@nateabele nateabele merged commit db79d76 into angular-ui:master Oct 30, 2015
@christopherthielen christopherthielen mentioned this pull request Feb 15, 2016
Closed
@christopherthielen christopherthielen mentioned this pull request Mar 1, 2016
Merged
@christopherthielen
Copy link
Contributor

christopherthielen commented Mar 1, 2016

@Frozenball @ghoullier @philBrown @SmuliS @petermolyneux

We're going to revert this PR, as deferring the scope destruction has caused all sorts of lifecycle issues.

Can you pull/build PR #2596 (pre 1.0.0-alpha.1) or PR #2597 (pre 0.2.19) and try using the $animLeave promise from $element.data('$uiView') instead?

Let me know if the animation promise will satisfy your use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

$destroy event is triggered on leaving view before animation/transition ends

4 participants

@Teemu @nateabele @christopherthielen @xtianus79