Merge in path-based params refactor #2338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e's hook registration logic to renamed StateHooks class
…e's hook registration logic to renamed StateHooks class
…resolved resolvables fetched during the original transition. closes #2274
- UrlMatchers are now tree-based, can be picked up and re-appended - UrlMatchers are now immutable - Param objects are now factoried through static methods - Parameters in URLs now have guaranteed ordering
…lic params: { [key: string]: Param }
- fetch Params[] dynamic using `values(this.params)`
- fix node.parameter()
- fix StateBuilder.url (do not expect state.params to be set, b/c 'params' is built after)
fix(PathFactory): reduce all path params to obj when creating TargetState fix(Node): normalize param values using Param.type when creating Node
…over UrlMatcher[] and concat to format a URL
- Remove overload of applyPairs (only allow [key, value] tuple)
christopherthielen
added a commit
that referenced
this pull request
Oct 26, 2015
Merge in path-based params refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.