fix($urlMatcherFactory): early binding of array handler bypasses type resolution

[ghost]

Is this (one of) the causes of issue #1048 ?

Please do NOT pull just yet as there are follow-up bugs which I didn't fix yet. Just wanted feedback whether I'm going in the right direction.

[christopherthielen]

Nice catch. I'm actually working on this code right now.

This is how I modified it:

    this.encode = arrayHandler(bindTo(type, type.encode));
    this.decode = arrayHandler(bindTo(type, type.decode));
    this.is     = arrayHandler(bindTo(type, type.is), true);
    this.equals = arrayEqualsHandler(bindTo(type, type.equals));
    this.pattern = type.pattern;
    this.$arrayMode = mode;

[ghost]

Hi Christoph, my patch actually is against master not one of the releases, so I think I got your change already. The code you posted above still seems to be affected as it binds the functions rather than keeping the object in the closure. (Sorry, I had to edit the text because I couldn't finish due to a "forced" software update.)

[christopherthielen]

@Jerico-Dev I'm not convinced that's necessary. However, don't spend too much time on it, as I've made significant changes to that area of the code that I haven't yet committed. I plan to commit later tonight.

[christopherthielen]

@Jerico-Dev I looked at your test and now see what you mean. Thank you!

[ghost]

For now I desisted using custom types as I had difficulties in formatting URLs (the custom type API was called sometimes with encoded values on encode() and sometimes with the decoded values on decode() and both on is(). Guess you're straightening this out in 0.2.13, so I'll hold on. If you like you can pull the fix then...

[christopherthielen]

FYI, .encode() gets called with encoded values. It is sorta like a .normalize() fn. However, .decode() should not be called with pre-decoded value.

[christopherthielen]

merged in via e9f8b8a

[ghost]

Re ".encode()" - that's good to know. :-) Maybe the docs in https://angular-ui.github.io/ui-router/site/#/api/ui.router.util.$urlMatcherFactory#methods_type and https://angular-ui.github.io/ui-router/site/#/api/ui.router.util.type:Type#methods_encode could be updated accordingly?