Skip to content

Can't use ES6 classes for actions #136

@bensgroi

Description

@bensgroi

The project I'm working on is written in ES6 and transpiled with babel. I can use classes for components just fine, but when attempting to use classes for actions and supply them to $ngRedux.connect, I get the following error: "'mapStateToScope' must return an object or a function. Instead received %s."

The check in question is here: https://github.com/angular-redux/ng-redux/blob/master/src/components/connector.js#L84 Specifically the lodash isPlainObject seems to be the problem. It seems like using isObject would make more sense here, and would allow transpiled ES6 classes as well.

I can submit a PR if you'd like.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions