Skip to content

Use stereo channel mask for AC-4 passthrough #2734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

Use stereo channel mask for AC-4 passthrough #2734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions libraries/exoplayer/src/main/java/androidx/media3/exoplayer/audio/AudioCapabilities.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,11 @@ public Pair<Integer, Integer> getEncodingAndChannelConfigForPassthrough(
if (channelCount > 10) {
return null;
}
} else if (format.sampleMimeType.equals(MimeTypes.AUDIO_AC4)) {
// AC-4 content may contain channel (or object) count that does not have a matching channel
// mask. Override channel count to 2 (mapped to stereo channel masK) which is supported by
// all AC-4 offloaded decoders to avoid this limitation and allow track to open.
channelCount = 2;
} else if (!audioProfile.supportsChannelCount(channelCount)) {
return null;
}
Expand Down